Approval Process

Every ticket will need to get approval from a group of people. These approvals are marked on the Ticket Summary wiki pages by those signing off the approval.

Tip

Make it really clear and easy for approvers to understand your change and know what needs approving - some get a lot of requests!

You may need to chase up approvals occasionally. People are not perfect and remember to be kind.

Tip

From vn13.2 the trac.log summary of your testing will also list all the Code and Config Owner approvals required in a handy table to make it easy to see what is required.

Note

LFRic Apps does not yet have a formal Code Owner approval process. A list of code owners is available and they should still be consulted as part of your development.

Code Owners

Every file in the codebases has a Code Owner, and every file changed will need checking by the code owners - no matter how small the change.

A list of current code owners for each project can be found in trunk/CodeOwners.txt.

Tip

It is always worth talking to the main code owners involved early in the process. These people have good oversight on changes in an area and will be able to guide your change to fit in with the bigger picture of what is happening.

Code Owners are good candidates for choosing as a SciTech reviewer.

Config Owner

Configuration Owner’s are responsible for a combination of settings in the model that achieve a particular aim (e.g. the current GAL or RAL setup used operationally). Within the rose-stem testing these configurations will be used and any changes to the answers shown in testing will need sign off from the config owner.

In some repositories, the code owner is supported by module leaders who will sign-off scientifically significant changes to their areas of interest. The module leaders in this case will also act as configuration owners for their science settings.

A list of current config owners for the UM is found in trunk/ConfigOwners.txt. Others are combined with the Code Owner lists above.

Optimisation Approvals

Changes that modify code within an OpenMP section will require approval from the HPC Optimisation Team. Changes that modify or add PSyKAl-lite code will require approval from the TCD Team.